Fix tests to run correctly using MacOS wc
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noticed in mfaerevaag#105, MacOS `wc -l` produces extra whitespace padding at the front of the word count. This makes it so that running the tests on MacOS produces false negatives. The fix here is to add a new function that calls `wc -l` then uses `sed` to strip out the extra whitespace. This is only used in the tests. After running this on a MacOS machine, all tests pass as expected.
|
Looks simple enough, thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in #105, MacOS
wc -lproduces extra whitespace padding atthe front of the word count. This makes it so that running the tests on
MacOS produces false negatives.
The fix here is to add a new function that calls
wc -lthen usessedto strip out the extra whitespace. This is only used in the tests.
After running this on a MacOS machine, all tests pass as expected.
Note: this doesn't address the bug listed in #105. This just fixes the problem
with running the tests.