Removed duplicate ConfigProvider from config/config.php

[bidi47]

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	no

Description

This PR fixes a bug in issue #162 by removing the duplicate ConfigProvider in config/config.php

[froschdesign]

@bidi47

Added ConfigProvider with full namespace for Mezzio\Helper…

The duplication is still present because the component installer automatically installs and injects the helpers:

mezzio-skeleton/composer.json

Lines 36 to 45 in 490b657

	"extra": {
	"laminas": {
	"component-whitelist": [
	"mezzio/mezzio",
	"mezzio/mezzio-helpers",
	"mezzio/mezzio-router",
	"laminas/laminas-httphandlerrunner"
	]
	}
	},

See: https://docs.laminas.dev/laminas-component-installer/#marking-packages-to-auto-install
(component-whitelist is also supported)

[froschdesign]

Please remove the entry from config.php and then please test it. Unfortunately, I can't test it at the moment. (Ignore the unit test for now.)

[bidi47]

@froschdesign, I see what you mean about the injections based on component-whitelist, but I tested locally on my end and found nothing to be duplicated. Apparently, the injection ignores \Mezzio\Helper\ConfigProvider::class if it's added to the aggregator with full namespace. Before, it was added with a use.

What I did to test:

• I ran composer create-project mezzio/mezzio-skeleton . in a new folder
• Before submitting anything, I edited config/config.php with the update I commited here
• I went through the installation process which completed successfully
• I ran composer serve to see the homepage

This is my config/config.php after the installation

<?php

declare(strict_types=1);

use Laminas\ConfigAggregator\ArrayProvider;
use Laminas\ConfigAggregator\ConfigAggregator;
use Laminas\ConfigAggregator\PhpFileProvider;

// To enable or disable caching, set the `ConfigAggregator::ENABLE_CACHE` boolean in
// `config/autoload/local.php`.
$cacheConfig = [
    'config_cache_path' => 'data/cache/config-cache.php',
];

$aggregator = new ConfigAggregator([
    \Mezzio\Twig\ConfigProvider::class,
    \Mezzio\Tooling\ConfigProvider::class,
    \Mezzio\Router\FastRouteRouter\ConfigProvider::class,
    \Laminas\HttpHandlerRunner\ConfigProvider::class,
    // Include cache configuration
    new ArrayProvider($cacheConfig),
    \Mezzio\Helper\ConfigProvider::class,
    \Mezzio\ConfigProvider::class,
    \Mezzio\Router\ConfigProvider::class,
    \Laminas\Diactoros\ConfigProvider::class,

    // Swoole config to overwrite some services (if installed)
    class_exists(\Mezzio\Swoole\ConfigProvider::class)
        ? \Mezzio\Swoole\ConfigProvider::class
        : function (): array {
            return [];
        },

    // Default App module config
    App\ConfigProvider::class,

    // Load application config in a pre-defined order in such a way that local settings
    // overwrite global settings. (Loaded as first to last):
    //   - `global.php`
    //   - `*.global.php`
    //   - `local.php`
    //   - `*.local.php`
    new PhpFileProvider(realpath(__DIR__) . '/autoload/{{,*.}global,{,*.}local}.php'),

    // Load development config if it exists
    new PhpFileProvider(realpath(__DIR__) . '/development.config.php'),
], $cacheConfig['config_cache_path']);

return $aggregator->getMergedConfig();

[froschdesign]

@bidi47
Thanks for testing! 👍🏻

In the meantime, I have also found the corresponding code location: https://github.com/laminas/laminas-component-installer/blob/5a2ebadbc6ecf81b38d84222170dbd773fc00d7f/src/Injector/AbstractInjector.php#L370-L379