Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_proxy_wrapper fails with -O, -E, and -F, missing new options. #25

Closed
tomalok opened this issue Dec 24, 2020 · 3 comments · Fixed by #26
Closed

log_proxy_wrapper fails with -O, -E, and -F, missing new options. #25

tomalok opened this issue Dec 24, 2020 · 3 comments · Fixed by #26

Comments

@tomalok
Copy link
Contributor

tomalok commented Dec 24, 2020

What happened to --stdout, --stderr, and --fifo-tmp-dir? I'm not seeing it in v0.4.0's log_proxy_wrapper --help...

$ /usr/bin/log_proxy_wrapper -F /var/log/log_proxy -O /var/log/docker.log -s 10485760 -t 0 -- /usr/bin/dockerd
Usage:
  log_proxy_wrapper [OPTION…] -- COMMAND [COMMAND_ARG1] [COMMAND_ARG2] [...] - log proxy

Help Options:
  -h, --help                Show help options

Application Options:
  -s, --rotation-size       maximum size (in bytes) for a log file before rotation (0 => no maximum, default: content of environment variable LOGPROXY_ROTATION_SIZE or 104857600 (100MB))
  -t, --rotation-time       maximum lifetime (in seconds) for a log file before rotation (0 => no maximum, default: content of environment variable LOGPROXY_ROTATION_TIME or 86400 (24H))
  -S, --rotation-suffix     strftime based suffix to append to rotated log files (default: content of environment variable LOGPROXY_ROTATION_SUFFIX or .%%Y%%m%%d%%H%%M%%S)
  -d, --log-directory       directory to store log files (default: content of environment variable LOGPROXY_LOG_DIRECTORY or current directory), directory is created if missing
  -n, --rotated-files       maximum number of rotated files to keep including main one (0 => no cleaning, default: content of environment variable LOGPROXY_ROTATED_FILES or 5)
  -m, --use-locks           use locks to append to main log file (useful if several process writes to the same file)

Specifically, i'm trying to use --fifo-tmp-dir (via the -F shortcut) and it's not there.

I'd also expect to be seeing the recent --chmod, --chown, and --chgrp, too. Those are showing up in the help for log_proxy itself -- just not the the proxy...

@tomalok tomalok changed the title log_proxy_wrapper log_proxy_wrapper fails with -O, -E, and -F, missing new options. Dec 24, 2020
@tomalok
Copy link
Contributor Author

tomalok commented Dec 24, 2020

77be7b7da998:/# strings /usr/bin/log_proxy | grep stderr
77be7b7da998:/# strings /usr/bin/log_proxy | grep stdout
77be7b7da998:/# strings /usr/bin/log_proxy | grep fifo
fifo
if set, read lines on this fifo instead of stdin
rm-fifo-at-exit
if set, drop fifo at then end of the program (you have to use --fifo option of course)

I suspect change_options() is not doing what you expect it to do.

@thefab
Copy link
Member

thefab commented Dec 28, 2020

thanks for this issue @tomalok

@thefab
Copy link
Member

thefab commented Dec 28, 2020

fixed in 0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants