Feature/package support #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package support/setup
…ent-ui # Conflicts: # app/ApiToken.php # database/migrations/2020_11_13_120125_create_api_tokens_table.php
[Feature] Add basic UI for API token management.
We hadn't hooked up the Registered event that is fired by default, so we never sent the email verification. Verification was being sent when specifically re-requesting it, however.
* Upgrade to Laravel 8 This moves us to L8. Most of the work has been put into making the tests pass, as we have moved to using the new, "improved" factories, rather than add the legacy factories package. Additionally we have moved models to a `Models` namespace, to be in line with how a new L8 project is structured in that regard. * Make changes based on review - Remove phpunit.xml.bak - Remove commented out code in TestCase.php
- API endpoints now back under /api - User model correctly set in auth config - Removed great big TODO because it isn't TODO
This also removes the workspaces API routes, as they only make sense using a user-level authentication, but we don't want to support doing that, as it would be the only routes that do, with everything else being a workspace-level authentication.
It was pushed to the right by a space between the text and the icon. It should now be consistent with the other menu items.
The Facades\Sendportal class was not correctly set up as a facade. It is unclear about how it was working before, but it stopped. The core package now correctly implements the facade, and additionally renames some of the methods to be clearer about what they do. This commit ensures that we use the facade from the core package correctly, largely by updating to use the new method names. Additionally, some minor adjustments have been made to the implementations of things like the workspace ID resolver, to make them a tiny bit more robust (checking for null and that sort of thing).
In theory this is okay, but need to push up to do some checks on actually upgrading installations from the old version. So as of this commit it's not guaranteed to be correct. Sorry.
The previous version of SP included the ability to use API tokens as either a Bearer token, or supplied as an `api_token` parameter in a request (GET or POST). This new packaged version removed that ability, but the various middlewares still let it through as a valid token, ending up hitting us with a RuntimeException thrown from the workspace ID resolver. We now check for the API token in the resolver bother as a bearer token and as an `api_token` parameter, and subsequently avoid seeing the RuntimeException in this case, with the advantage of keeping a little backward compatibility with v1.
rockbuzz-dev
pushed a commit
to rockbuzz-dev/sendportal
that referenced
this pull request
Jan 29, 2022
Feature/package support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.