Split campaigns index #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonoB
approved these changes
Mar 5, 2021
mauricius
approved these changes
Mar 5, 2021
joshuafranks
approved these changes
Mar 5, 2021
dljfield
reviewed
Mar 5, 2021
| /** | ||
| * @throws Exception | ||
| */ | ||
| public function sent(): ViewContract |
There was a problem hiding this comment.
I think that, if we're going to go down the route of splitting draft and sent as domain concepts, we should move this to its own controller as an index method.
Alternatively, we should just make draft/sent be query parameters that are sent to the single campaign index, as that's really the only difference at the moment.
There was a problem hiding this comment.
This was basically replicated from MessagesController to keep it consistent.
I think I'd pick the params only because a controller feels like overkill but happy to go with whichever people feel is most appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
mettle/sendportal#81
Description
Split campaigns index into draft and sent tabs.