Delete failed messages on subscriber deletion #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauricius
approved these changes
Mar 5, 2021
joshuafranks
approved these changes
Mar 5, 2021
added 3 commits
March 5, 2021 11:06
This adds a test for the deletion of a subscriber's messages and any associated message failures. In adding this test, I realised that - because we were performing a mass deletion - eloquent events were not being fired. This meant that the failures were not being deleted and the operation would bomb out due to a constraint error. I'm in two minds as to whether the loop and delete per-message is better than a mass deletion with a loop that just handles the messages in our subscriber class. I think the deletion of a message's failures should be done at the Message level to ensure consistent behaviour and in practice, this should be a relatively inexpensive operation.
Although it adds some duplication, the performance benefits are simply more valuable.
dljfield
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
mettle/sendportal#116
Description
Delete failed messages on subscriber deletion.