Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For macos and ios switch from mach crate to mach2 crate #79

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

oherrala
Copy link
Contributor

@oherrala oherrala commented Feb 20, 2023

mach crate seems abandoned while mach2 crate is more actively updated. Warning has been published in RUSTSEC-2020-0168. This shouldn't have any functional change.

See:

mach crate seems abandoned while mach2 crate is more actively updated.
@jqnatividad
Copy link

GitHub's dependabot has started automatically opening issues in crates that use mach.

fitzgen/mach#63

It'd be great if this PR can be merged.

@tobz tobz merged commit cf035b8 into metrics-rs:main Mar 21, 2023
@tobz
Copy link
Member

tobz commented Mar 21, 2023

While I have to admit that I'm not a fan of RUSTSEC advisories being used just for marking crates as unmaintained when there's no specific security issue... I also realize that having to deal with those warnings, and having to exclude specific warnings, sucks.

This seemed pretty straightforward, so I went ahead with merging.

I have a few other tweaks and things to likely merge in the next few days/week or so, so I'll try and cut a release once things look like they're solidified on my end.

@oherrala oherrala deleted the switch-to-mach2 branch March 21, 2023 10:28
@oherrala
Copy link
Contributor Author

While I have to admit that I'm not a fan of RUSTSEC advisories being used just for marking crates as unmaintained when there's no specific security issue

This is offtopic and there's no need to continue this discussion further. But:

Unmaintained crates might have security issues and bugs, etc. but since they get no attention there's no reason to security audit or fix bugs since nobody is going to merge the fixes. And for example RUSTSEC-2023-0020 is one crate which was first reported as unmaintained, but further look into source code revealed two other issues making unmaintained crate a security issue.

And it might also happen that when a crate is reported as unmaintained someone might step up and make a fork. That's what happened to buf_redux and it's now forked as buffer_redux.

Unmaintained advisories serve the community to raise awareness and help take care of the supply chain before unmaintained crates grow to bigger issues.

@tobz
Copy link
Member

tobz commented Mar 24, 2023

@oherrala This PR is now released as of [email protected].

Thanks again for your contribution. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants