Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

为已存在号码添加国际区号, 并补充 "招商银行金葵花专线" (解决冲突文件后重提交 PR #372) #374

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

Zikinn
Copy link
Contributor

@Zikinn Zikinn commented Feb 9, 2024

说明:

添加国际区号的原因:

在 macOS 及非插卡的 iPadOS 上, 若设备地区设置不是 CN, 则按照设置的地区解析号码, 例如地区设置为 US 时, 186 5xxx xxxx 会被解析为 +1 (865) xxx-xxxx; 此外在海外接打电话时也会显示国际区号

下图为是否添加国际区号的差别:
image

补充 "招商银行金葵花专线"

Ref. https://www.cmbchina.com/personal/Sunflower/Sunflowercfgl.aspx

@metowolf metowolf merged commit d035445 into metowolf:master Mar 4, 2024
1 check failed
@Xm798
Copy link

Xm798 commented Mar 13, 2024

添加区号后,如 95559 的短号码在短信中无法被识别为联系人。

cc @metowolf

@Zikinn
Copy link
Contributor Author

Zikinn commented Mar 13, 2024

添加区号后,如 95559 的短号码在短信中无法被识别为联系人。

cc @metowolf

真没想到这种情况…

看起来需要单独开一个 oversea 的 branch 或者单独输出一个文件了, 可能需要改 CI 🫠

@metowolf
Copy link
Owner

短号看起来要再考虑下,我这边先做 rollback

@Zikinn
Copy link
Contributor Author

Zikinn commented Mar 13, 2024

@metowolf 要不先 git reset, 我研究下 CI , 改完再提 PR?

试试看能不能让 IC 单独输出一个带区号的文件.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants