Disable *transformer* variable inside a transformer call #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timclemons
reviewed
Dec 15, 2020
miikka
changed the title
|
@wandersoncferreira I merged #248 and took a look at this. The change looks good, so if you update ih to work with the latest master, I'd be happy to merge it. Thanks again for your work! |
…o bugfix/allow-s-valid-inside-transformer
|
Great @miikka , thanks for taking the time to look at these PRs. I made the adjustments |
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 87.99% 88.01% +0.01%
==========================================
Files 16 16
Lines 2049 2052 +3
Branches 183 183
==========================================
+ Hits 1803 1806 +3
Misses 63 63
Partials 183 183
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea about how to solve #240 . The solution here is to disable the
*transformer*dynamic variable when a transform function is called. I think this is a reasonable thing to do to avoid StackOverFlow scenarios.There is more details in #240 thread.
Thanks