visitor/visit doesn't seem to work on merged specs

[polvoblanco]

Hi,

I have some specs created at run-time from databased maps of required and optional Data Specs (persisted as strings and read in as edn). However, when I try and visit specs created by merging these two sets of keys (to get the full spec) it returns an empty map.

e.g.
[metosin/spec-tools "0.7.0"]

(require '[spec-tools.core :as st]
               '[spec-tools.data-spec :as ds]
               '[spec-tools.visitor :as visitor])

(visitor/visit
   (st/merge (ds/spec {:spec {:required/str string?}})
             (ds/spec {:spec {:optional/str string?}
                       :keys-default ds/opt}))
   (visitor/spec-collector))

Returns {}

The un-merged specs visit as expected, but when merged together they don't seem to work.

Thanks,

Paul

[ikitommi]

Sounds like a bug. I think spec-tools.core/merge doesn't have a dispatch value for visit-spec. PR welcome to fix this.

[slipset]

#173 is a duplicate of this issue, but has a PR (#174)

[miikka]

Just to clarify: #173 is not a duplicate of this issue and merging data-spec still does not work.