Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom handler for resource 404 #155

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Custom handler for resource 404 #155

merged 2 commits into from
Oct 16, 2018

Conversation

valerauko
Copy link
Contributor

Issue

#89

Changes

Added optional :not-found-handler param to create-resource-handler.

It defaults to the same constantly as create-default-handler does.

Tests

All current clj tests are green.

I didn't add tests for the new parameter -- should I? If so, to all the test branches (inside/outside router, root/path)?

@ikitommi ikitommi merged commit a77a583 into metosin:master Oct 16, 2018
@ikitommi
Copy link
Member

Thanks!

@valerauko valerauko deleted the resource-404 branch October 16, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants