feat: add pos? and neg? to predicate-schemas
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikitommi
reviewed
Aug 30, 2020
Adds the core `pos?` and `neg?` functions to the predicate schemas. This is useful for when you don't care about the type of numeric, (ie. int vs double vs float) and only the sign of it. Also useful for constructing `[:and pos? float?]` if you want positive floats.
|
@ikitommi Thanks for the review. Updated w/ generators and json-schema mappings. |
rschmukler
force-pushed
the
rschmukler/add-predicate-schemas
branch
from
54fa6f2 to
623a5d9
Compare
|
Thanks! |
|
there was one more place: a6d38fa |
|
@rschmukler coudn't make you a reviewer on #212 , but would you have time to take a look at it? if the diff is too messy (it is), I could cherry pick the code formatting & moving around into separate issue. |
|
@ikitommi will take a look! Thanks for the help getting this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the core
pos?andneg?functions to the predicate schemas. Thisis useful for when you don't care about the type of numeric, (ie. int vs
double vs float) and only the sign of it.
Also useful for constructing
[:and pos? float?]if you want positive floats.