feat: interceptor based transformers #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the idea surfaced in metosin#114. This commit introduces interceptor based transformers by using the `:enter` and `:leave` keys returned on the `-value-transformer` function. Naively it uses almost identical implementations for all enter and exit applications, with the only exception being the collection-based transformers which do look at the phase to avoid double wrapping collections. Ultimately there might be some occassions where we could speed things up even more (eg. not reducing over a collection if there isn't a mapping function anyway) but those optimizations don't exist in the current implementation either, so this PR doesn't attempt to resolve any of that.
rschmukler
force-pushed
the
rschmukler/interceptor-based-transformers
branch
from
bb2b49a to
7d65517
Compare
This was referenced Nov 25, 2019
|
Looks good, I'll add some tests see if something is missing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the idea surfaced in #114.
This commit introduces interceptor based transformers by using the
:enterand:leavekeys returned on the-value-transformerfunction.
Naively it uses almost identical implementations for all enter and exit
applications, with the only exception being the collection-based
transformers which do look at the phase to avoid double wrapping
collections.
Ultimately there might be some occassions where we could speed things up
even more (eg. not reducing over a collection if there isn't a mapping
function anyway) but those optimizations don't exist in the current
implementation either, so this PR doesn't attempt to resolve any of
that.