Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no overlays for now #1451

Merged
merged 2 commits into from
Dec 10, 2024
Merged

no overlays for now #1451

merged 2 commits into from
Dec 10, 2024

Conversation

charlienegri
Copy link
Collaborator

@charlienegri charlienegri commented Dec 10, 2024

Change Summary

apparently this is not desired before May, and probably not until we can make overlays for all models

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@charlienegri charlienegri marked this pull request as ready for review December 10, 2024 09:56
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.43%. Comparing base (f835cd8) to head (239efbc).
Report is 66 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1451   +/-   ##
=========================================
  Coverage     78.43%   78.43%           
=========================================
  Files           137      137           
  Lines         20961    20961           
=========================================
  Hits          16440    16440           
  Misses         4521     4521           
Flag Coverage Δ
unittests 78.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake merged commit 321b0af into main-dev Dec 10, 2024
8 checks passed
@lewisblake lewisblake deleted the no_pixelmaps branch December 10, 2024 14:48
@heikoklein heikoklein added this to the m2025-01 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants