Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests with py3.13 #1442

Merged
merged 2 commits into from
Dec 11, 2024
Merged

CI tests with py3.13 #1442

merged 2 commits into from
Dec 11, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Dec 4, 2024

Change Summary

Related issue number

closes #1436

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.43%. Comparing base (afb073d) to head (c30880f).
Report is 59 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1442      +/-   ##
============================================
- Coverage     78.57%   78.43%   -0.14%     
============================================
  Files           137      137              
  Lines         20892    20961      +69     
============================================
+ Hits          16415    16440      +25     
- Misses         4477     4521      +44     
Flag Coverage Δ
unittests 78.43% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magnusuMET magnusuMET linked an issue Dec 5, 2024 that may be closed by this pull request
@thorbjoernl thorbjoernl marked this pull request as ready for review December 9, 2024 09:56
@lewisblake lewisblake requested a review from avaldebe December 9, 2024 10:20
@thorbjoernl thorbjoernl added this to the m2025-01 milestone Dec 10, 2024
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we do not test against Python 3.11 on CI?

.github/workflows/CI.yml Show resolved Hide resolved
pyproject.toml Outdated
@@ -197,7 +198,7 @@ max-line-length = 99
[tool.tox]
legacy_tox_ini = """
[tox]
envlist = py310, py311, py312, lint, type-check, docs, build
envlist = py310, py312, py313, lint, type-check, docs, build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to remove the tox environment for Python 3.11, even if we wont test against it on CI

Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thorbjoernl thorbjoernl merged commit d946366 into main-dev Dec 11, 2024
7 of 8 checks passed
@thorbjoernl thorbjoernl deleted the python-3.13 branch December 11, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for 3.13
2 participants