Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strings in name dictionaries #1432

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix strings in name dictionaries #1432

merged 1 commit into from
Nov 28, 2024

Conversation

charlienegri
Copy link
Collaborator

@charlienegri charlienegri commented Nov 28, 2024

Change Summary

names were swapped, causing issues for cams2_83 when filling with NaNs non-existing IFS variables

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@charlienegri charlienegri marked this pull request as ready for review November 28, 2024 10:26
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.57%. Comparing base (917d2fd) to head (2629a87).
Report is 5 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1432      +/-   ##
============================================
- Coverage     78.57%   78.57%   -0.01%     
============================================
  Files           137      137              
  Lines         20890    20892       +2     
============================================
  Hits          16415    16415              
- Misses         4475     4477       +2     
Flag Coverage Δ
unittests 78.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heikoklein heikoklein merged commit fec1c5d into main-dev Nov 28, 2024
7 of 8 checks passed
@heikoklein heikoklein deleted the fix_names branch November 28, 2024 11:15
@heikoklein heikoklein added this to the m2024-12 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants