Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obs name big fix #1427

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Obs name big fix #1427

merged 2 commits into from
Nov 26, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Nov 26, 2024

Change Summary

place obs_name as attribute in ObsEntry. set in the ObsCollection setter, not the getter. Fix tests to not use the ObsCollection getter. unrealistic.

Related issue number

N/A, see chat

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@lewisblake lewisblake added the bug 🐛 Something isn't working label Nov 26, 2024
@lewisblake lewisblake added this to the m2024-12 milestone Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.57%. Comparing base (8d55c2b) to head (917d2fd).
Report is 4 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1427      +/-   ##
============================================
- Coverage     78.58%   78.57%   -0.01%     
============================================
  Files           137      137              
  Lines         20889    20890       +1     
============================================
  Hits          16415    16415              
- Misses         4474     4475       +1     
Flag Coverage Δ
unittests 78.57% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake marked this pull request as ready for review November 26, 2024 13:30
@lewisblake lewisblake merged commit 323fab6 into main-dev Nov 26, 2024
8 checks passed
@lewisblake lewisblake deleted the obs_name_big_fix branch November 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants