Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases for for vmrno2 and vmro3 #1422

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add aliases for for vmrno2 and vmro3 #1422

merged 1 commit into from
Nov 25, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Nov 25, 2024

Change Summary

Related issue number

see if gets maps to show up
attempt at fixing #1389

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (413f9b8) to head (aa4c23e).
Report is 3 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1422   +/-   ##
=========================================
  Coverage     78.35%   78.35%           
=========================================
  Files           137      137           
  Lines         20889    20889           
=========================================
  Hits          16367    16367           
  Misses         4522     4522           
Flag Coverage Δ
unittests 78.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lewisblake lewisblake marked this pull request as ready for review November 25, 2024 11:41
@lewisblake lewisblake added this to the m2024-12 milestone Nov 25, 2024
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@jgriesfeller jgriesfeller merged commit 6ef2101 into main-dev Nov 25, 2024
8 checks passed
@lewisblake lewisblake deleted the alias_vmr branch November 25, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants