Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ifs model to list #1420

Merged
merged 1 commit into from
Nov 22, 2024
Merged

add ifs model to list #1420

merged 1 commit into from
Nov 22, 2024

Conversation

charlienegri
Copy link
Collaborator

@charlienegri charlienegri commented Nov 22, 2024

Change Summary

we will start evaluating some IFS data too and a new model entry is needed
the data will be placed in the same location as and with a format indistinguishable from the current cams2_83 model data so this is the only change required on the pyaerocom side

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (975e047) to head (413f9b8).
Report is 3 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1420   +/-   ##
=========================================
  Coverage     78.35%   78.35%           
=========================================
  Files           137      137           
  Lines         20888    20889    +1     
=========================================
+ Hits          16366    16367    +1     
  Misses         4522     4522           
Flag Coverage Δ
unittests 78.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@charlienegri charlienegri marked this pull request as ready for review November 22, 2024 10:11
@heikoklein heikoklein added this to the m2024-12 milestone Nov 22, 2024
@heikoklein heikoklein merged commit 1592dbe into main-dev Nov 22, 2024
8 checks passed
@heikoklein heikoklein deleted the cams283_add_ifs branch November 22, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants