Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variables_changed_units_categories #1418

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

andrearosendahl
Copy link
Collaborator

@andrearosendahl andrearosendahl commented Nov 22, 2024

Change Summary

Added two more categories for the variables, surface emission and column burden. Also changed the units for some deposition, emission and load variables.

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@andrearosendahl andrearosendahl marked this pull request as draft November 22, 2024 07:52
@andrearosendahl andrearosendahl marked this pull request as ready for review November 22, 2024 07:53
@jgriesfeller jgriesfeller added the good first issue Good for newcomers label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.45%. Comparing base (f39ea68) to head (6d2a8a6).
Report is 46 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1418   +/-   ##
=========================================
  Coverage     78.44%   78.45%           
=========================================
  Files           137      137           
  Lines         20950    20952    +2     
=========================================
+ Hits          16435    16437    +2     
  Misses         4515     4515           
Flag Coverage Δ
unittests 78.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake added this to the m2025-01 milestone Dec 2, 2024
@lewisblake
Copy link
Member

lewisblake commented Dec 9, 2024

Note from pyaerocom 09.12.24: It could be useful make variables.ini user confifgurable at some time. Since NorESM is the main user of these variables at this time, it makes sense to merge these changes.

Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old units are those in the CF convention. But if they don't show nicely on aeroval, that fact doesn't help. Since the units are convertable via cf_units: approved.

@jgriesfeller jgriesfeller merged commit 1dee3b4 into metno:main-dev Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants