Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trends to run even if a component does not have any data due to min_yrs constraints #1313

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Aug 18, 2024

Trends may have a min_yrs constraint rejection all stations which haven't measured at least min_yrs. This can lead to components having 0 data. 0 data crashed pyaerocom (or raised a TrendException). This PR changes the behaviour so that 0 data of a trend-analysis is an acceptable result. It will be logged if the min_yrs constraint removed all stations.

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@heikoklein heikoklein added this to the m2024-09 milestone Aug 18, 2024
@heikoklein heikoklein requested a review from dulte August 18, 2024 12:15
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (8355b4a) to head (2e9608f).
Report is 313 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/geodesy.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1313      +/-   ##
============================================
- Coverage     79.00%   78.99%   -0.01%     
============================================
  Files           136      136              
  Lines         20797    20798       +1     
============================================
  Hits          16430    16430              
- Misses         4367     4368       +1     
Flag Coverage Δ
unittests 78.99% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@heikoklein heikoklein marked this pull request as ready for review August 19, 2024 06:49
Copy link
Collaborator

@dulte dulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@heikoklein heikoklein merged commit 0277ed6 into main-dev Aug 21, 2024
8 checks passed
@heikoklein heikoklein deleted the emep-long-trends branch August 21, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants