-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emep base-config for reporting #1276
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1276 +/- ##
============================================
+ Coverage 78.96% 79.04% +0.08%
============================================
Files 133 135 +2
Lines 20599 20766 +167
============================================
+ Hits 16265 16414 +149
- Misses 4334 4352 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up dead code. I also wonder if we should link to the documentation in the config.
public=True, | ||
# directory where colocated data files are supposed to be stored | ||
weighted_stats=True, | ||
var_order_menu=[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should try to model "good behavior" in this config by supplying the data types that EvalSetup
actually expects. So for var_order_menu
, this is a tuple of strings, not a list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should be able to add or remove variable in the var_order_menu before sending it to EvalSetup. This becomes unnecessarily cumbersome if it is a tuple. EvalSetup/pedantic to the cleanup/conversion to tuples.
Change Summary
The emep config is very long and modellers repeatedly used inconsistent versions of the base-config. Therefore, a base-config with the most common parameters is bundled with pyaerocom. The modeller only needs to adapt the base-config.
Related issue number
fixes https://github.com/metno/AeroToolsIssues/issues/2
Checklist