Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDA8 timestamp and superfluous values #1265

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jul 15, 2024

Change Summary

  • MDA8 values will now have the interval midpoint as their timestamp (ie. 1pm / 13:00 instead of 1am / 01:00).
  • MDA8 will not include calculated values for days which did not have at least one data point in the input timeseries.

Related issue number

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally (Except test_readgridded/test_years_available)
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added the bug 🐛 Something isn't working label Jul 15, 2024
@thorbjoernl thorbjoernl added this to the m2024-08 milestone Jul 15, 2024
@thorbjoernl thorbjoernl force-pushed the mda8-remove-excessive-values branch from 947c344 to 50e3118 Compare July 15, 2024 09:45
@thorbjoernl thorbjoernl self-assigned this Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.35%. Comparing base (816b2cc) to head (bb81351).
Report is 44 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1265   +/-   ##
=========================================
  Coverage     79.34%   79.35%           
=========================================
  Files           133      133           
  Lines         20421    20424    +3     
=========================================
+ Hits          16204    16207    +3     
  Misses         4217     4217           
Flag Coverage Δ
unittests 79.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl requested a review from heikoklein July 15, 2024 11:53
@thorbjoernl thorbjoernl marked this pull request as ready for review July 15, 2024 11:53
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try my suggestion, otherwise this looks fine and I approve.

@thorbjoernl thorbjoernl merged commit 7b2c5c1 into main-dev Jul 15, 2024
6 checks passed
@thorbjoernl thorbjoernl deleted the mda8-remove-excessive-values branch July 15, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDA8 daily values have wrong timestamp MDA8 calculation for single year results in ts of two years
2 participants