Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make web- variables, colormaps and scales configurable #1256

Merged
merged 15 commits into from
Jul 11, 2024
Merged

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Jul 10, 2024

Change Summary

  • Convert definitions in python code glob_defaults.py to .ini files (var_web_info and var_ranges_defaults)
  • Allow above configurations to be overruled/extended by the same ini-files in user-space
  • remove unnecessary check-ranges test since now default-ranges are used

Related issue number

fixes #1221
fixes #1248

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 88.43537% with 17 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (2dad9c7) to head (d9f234a).
Report is 504 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/glob_defaults.py 86.92% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1256      +/-   ##
============================================
+ Coverage     79.32%   79.37%   +0.05%     
============================================
  Files           133      133              
  Lines         20316    20439     +123     
============================================
+ Hits          16115    16223     +108     
- Misses         4201     4216      +15     
Flag Coverage Δ
unittests 79.37% <88.43%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heikoklein heikoklein added this to the m2024-08 milestone Jul 11, 2024
@heikoklein heikoklein requested a review from lewisblake July 11, 2024 14:26
@heikoklein heikoklein marked this pull request as ready for review July 11, 2024 14:27
pyaerocom/aeroval/setupclasses.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/setupclasses.py Outdated Show resolved Hide resolved
tests/aeroval/test_setupclasses.py Outdated Show resolved Hide resolved
@lewisblake lewisblake merged commit 0842fc6 into main-dev Jul 11, 2024
8 checks passed
@lewisblake lewisblake deleted the scales branch July 11, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants