Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBAS reader: open db in read only mode only #1233

Merged

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Jun 28, 2024

Change Summary

the title says it all

Related issue number

fix #1232

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller linked an issue Jun 28, 2024 that may be closed by this pull request
@jgriesfeller jgriesfeller self-assigned this Jun 28, 2024
@jgriesfeller jgriesfeller added this to the m2024-07 milestone Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (a95b5c2) to head (f453e71).
Report is 457 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1233   +/-   ##
=========================================
  Coverage     79.30%   79.30%           
=========================================
  Files           131      131           
  Lines         20238    20245    +7     
=========================================
+ Hits          16049    16056    +7     
  Misses         4189     4189           
Flag Coverage Δ
unittests 79.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller requested a review from lewisblake June 28, 2024 09:11
@jgriesfeller jgriesfeller marked this pull request as ready for review June 28, 2024 09:12
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@lewisblake lewisblake merged commit 383a2ee into main-dev Jun 28, 2024
8 checks passed
@lewisblake lewisblake deleted the 1232-ebas-reader-open-sqlite3-db-in-read-only-mode-only branch June 28, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EBAS reader: open sqlite3 db in read-only mode only
2 participants