Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve variable naming #1194

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Improve variable naming #1194

merged 5 commits into from
Jun 11, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jun 10, 2024

Change Summary

  • Improved variable naming mainly in ExperimentOutput.
  • Adds type hinting.
  • Removes superfluous if check (EvalSetup no longer has var_mapping).
  • Use namedtuple for tuple return types.

Related issue number

NA

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (16208c7) to head (ac80b76).
Report is 491 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/experiment_output.py 95.65% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1194      +/-   ##
============================================
+ Coverage     79.26%   79.31%   +0.05%     
============================================
  Files           131      131              
  Lines         20239    20230       -9     
============================================
+ Hits          16042    16046       +4     
+ Misses         4197     4184      -13     
Flag Coverage Δ
unittests 79.31% <95.83%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl added this to the m2024-07 milestone Jun 10, 2024
@thorbjoernl thorbjoernl requested a review from lewisblake June 10, 2024 14:35
@thorbjoernl thorbjoernl marked this pull request as ready for review June 10, 2024 16:49
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This is a valuable update, thanks.

@lewisblake lewisblake merged commit a126413 into main-dev Jun 11, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the variable-cleanup-in-exp-output branch August 19, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants