Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes raising wrong exceptions, left over from #1090 #1133

Closed
wants to merge 1 commit into from

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Apr 22, 2024

Change Summary

Fix exceptions

Related issue number

NA

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2024-05 milestone Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.25%. Comparing base (cadc4ab) to head (1753611).
Report is 1 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/aeroval/coldatatojson_engine.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1133   +/-   ##
=========================================
  Coverage     79.25%   79.25%           
=========================================
  Files           110      110           
  Lines         19103    19103           
=========================================
  Hits          15140    15140           
  Misses         3963     3963           
Flag Coverage Δ
unittests 79.25% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review April 22, 2024 12:09
@lewisblake lewisblake closed this May 6, 2024
@thorbjoernl thorbjoernl deleted the fix-exceptions branch August 19, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants