Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to node/python ingestor(s) #51

Merged
merged 8 commits into from
Oct 26, 2022

Conversation

AHarmlessPyro
Copy link
Contributor

For both :

  • Verify that metlo url is a valid url (no support for verification of ingestor actually being present at that address).
  • Require only base urls in node ingestor, so that the endpoint name itself isn't required.
  • Mention source in ingestors

For node :

  • Use axios instead of node https
    • This allows simple redirect follows and auto resolution of http/https, so no manual switching would be required.
  • For express, modify sendfiles wrapper so that response is captured properly.

@AHarmlessPyro AHarmlessPyro merged commit 786710f into develop Oct 26, 2022
@AHarmlessPyro AHarmlessPyro deleted the ingestor_improvements branch October 27, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants