Add cleanup for gcp cli mirroring #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay288
approved these changes
Nov 19, 2022
cli/src/gcp/cleanup.ts
Outdated
| if (metloRegexResp.length != 2) { | ||
| throw new Error("Packet Mirroring policy didn't match expected pattern. Please try manual deletion.") | ||
| } | ||
| let metloId = regexPattern.exec(mirrorInstance.name)[1] |
There was a problem hiding this comment.
validate that this is a uuid
cli/src/gcp/cleanup.ts
Outdated
| // Delete GCP Packet Mirroring | ||
| try { | ||
| let resp_pack = await conn.stop_packet_mirroring({ | ||
| packetMirroringURL: mirrorInstance.selfLink.split("/").at(-1), |
There was a problem hiding this comment.
pull out and validate uuid
| spinner.succeed("Deleted Forwarding Rule") | ||
|
|
||
| spinner.start("Deleting Load Balancer") | ||
| const [backends, ,] = await conn.list_backend_service() |
cli/src/gcp/cleanup.ts
Outdated
|
|
||
| spinner.start("Deleting Health Check") | ||
| const [healthChecks, ,] = await conn.list_health_checks() | ||
| const check = healthChecks.find((_check) => _check.name.includes(metloId)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.