(bugfix) fix useEffect missing dependancy array warnings for gcp and …

…aws connections
metlo-labs · Sep 4, 2022 · 4fb13ce · 4fb13ce
1 parent b9ed745
commit 4fb13ce
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/frontend/src/components/ConnectionConfiguration/AWS/instance_selection.tsx b/frontend/src/components/ConnectionConfiguration/AWS/instance_selection.tsx
@@ -42,6 +42,7 @@ const InstanceSelection: React.FC<KeySetupInterface> = ({
     })
 
   const toast = useToast()
+
   useEffect(() => {
     if (isCurrent) {
       setLoadingState(true)
@@ -66,7 +67,8 @@ const InstanceSelection: React.FC<KeySetupInterface> = ({
         })
         .finally(() => setLoadingState(false))
     }
-  }, [selectedInstanceSpecs, isCurrent])
+  }, [selectedInstanceSpecs, toast, isCurrent, id, setLoadingState])
+
   if (instances != null) {
     return (
       <Grid

diff --git a/frontend/src/components/ConnectionConfiguration/AWS/os_selection.tsx b/frontend/src/components/ConnectionConfiguration/AWS/os_selection.tsx
@@ -41,7 +41,8 @@ const OsSelection: React.FC<KeySetupInterface> = ({
         })
         .catch(err => {})
     }
-  }, [isCurrent])
+  }, [isCurrent, id])
+
   if (OSChoices != null) {
     return (
       <Grid

diff --git a/frontend/src/components/ConnectionConfiguration/GCP/destination_instance_config.tsx b/frontend/src/components/ConnectionConfiguration/GCP/destination_instance_config.tsx
@@ -47,7 +47,7 @@ const SourceMigConfig: React.FC<KeySetupInterface> = ({
           console.warn(err)
         })
     }
-  }, [isSelected])
+  }, [isSelected, id, toast])
 
   return (
     <Grid

diff --git a/frontend/src/components/ConnectionConfiguration/common/genericStep.tsx b/frontend/src/components/ConnectionConfiguration/common/genericStep.tsx
@@ -16,7 +16,8 @@ const GenericStep: React.FC<GenericStepAWSInterface> = ({
     if (isCurrent) {
       complete({})
     }
-  }, [isCurrent])
+  }, [isCurrent, complete])
+
   return (
     <Flex w={"full"} h={"full"} justify={"center"} mt={8}>
       <Spinner size={"xl"} />