Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tables method #72

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Fix tables method #72

merged 1 commit into from
Dec 13, 2019

Conversation

lienvdsteen
Copy link

@lienvdsteen lienvdsteen commented Dec 9, 2019 •
edited
Loading

Description

The response of the API call does not return this with tables key. See the documentation.

Related Issue

#71

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fix tables method
039fb86 
 The response of the API call does not return this with tables key.
See https://documentation.bamboohr.com/reference#metadata-get-a-list-of-tabular-fields-1
@chrisman chrisman changed the base branch from master to develop December 13, 2019 18:56
@chrisman chrisman merged commit 34b87d9 into method-inc:develop Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisman chrisman chrisman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lienvdsteen @chrisman