Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jQuery with HTTP package #2

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

jehartzog
Copy link

I moved over this PR by @gbhrdt to this repo, would very much like to no longer include jQuery v1.11.10 in my Meteor bundle. Thank you!

@skirunman
Copy link

@abernix @timbotnik Not sure who is maintaining this package, but we were analyzing our production build and saw that jQuery had snuck back in adding 100kb to the image size. As a paying user of Galaxy Pro with Meteor APM we'd like to request that this PR get accepted to remove this unneeded dependency. This is time critical for us as we are just about to release a new production version of our app. Without this PR we will have to fork and support our own package. Thanks!

@timbotnik timbotnik merged commit 2ae1674 into meteor:master Oct 16, 2017
@jehartzog jehartzog deleted the remove-jquery branch October 16, 2017 23:28
@timbotnik
Copy link

@jehartzog @skirunman @gbhrdt we've merged this PR & published v3.1.0, which includes 1 bug fix for the "Content-Type" header on top of this PR. 26973ad Please test and verify that everything works as expected ;-)

@jehartzog
Copy link
Author

@timbotnik I've pushed this to my Galaxy app and it looks good, APM data is still coming in.

I was unsuccessful in removing the jQuery Meteor package from my bundle, turns out I had created this PR before I had updated to use the handy meteor list --tree command and didn't catch that jQuery was still being snuck into my bundle by accounts-ui here and here, but that's a battle for me to work another day.

Thanks again for accepting the PR.

@gbhrdt
Copy link

gbhrdt commented Oct 17, 2017

Thanks for merging! One step further to make our meteor bundle smaller and the web faster.

@skirunman
Copy link

Things look to be working for us on Galaxy with APM. Thanks guys for being so responsive, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants