GdalXmlNode::fmt(): use explicit VSIFree() #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reviewing the code, I was wondering if it wasn't leaking, but it seems not in practice. However using CString::from_raw() seems a bit dangerous and relies on non specified behaviour, as the documentation of that function mentions 'Retakes ownership of a CString that was transferred to C via CString::into_raw', which isn't the case here. The fact that it worked in practice comes from the fact the default deallocator used behind the scenes by CString is free(), and that VSIFree() is also an alias for that.
metasim
force-pushed
the
feature/warp
branch
from
9e9ba71 to
c6438bb
Compare
metasim
force-pushed
the
feature/warp
branch
3 times, most recently
from
b3d68e3 to
a16e93b
Compare
metasim
force-pushed
the
feature/warp
branch
2 times, most recently
from
576c57a to
74edd48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing the code, I was wondering if it wasn't leaking, but it seems not in practice. However using CString::from_raw() seems a bit dangerous and relies on non specified behaviour, as the documentation of that function mentions 'Retakes ownership of a CString that was transferred to C via CString::into_raw', which isn't the case here. The fact that it worked in practice comes from the fact the default deallocator used behind the scenes by CString is free(), and that VSIFree() is also an alias for that.
CHANGES.mdif knowledge of this change could be valuable to users.