-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce metapath expression evaluator subcommand WIP #96
introduce metapath expression evaluator subcommand WIP #96
Conversation
WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MetapathCommand
participant TestPathSubCommand
User->>MetapathCommand: Invoke test-path command
MetapathCommand->>TestPathSubCommand: Handle command
TestPathSubCommand->>User: Validate input arguments
TestPathSubCommand->>TestPathSubCommand: Compile MetaPath expression
TestPathSubCommand->>User: Execute command and return results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- metaschema-cli/src/main/java/gov/nist/secauto/metaschema/cli/commands/metapath/MetapathCommand.java (1 hunks)
- metaschema-cli/src/main/java/gov/nist/secauto/metaschema/cli/commands/metapath/TestPathSubCommand.java (1 hunks)
Additional comments not posted (7)
metaschema-cli/src/main/java/gov/nist/secauto/metaschema/cli/commands/metapath/MetapathCommand.java (1)
17-17
: LGTM!The new command handler
TestPathSubCommand
is correctly added.The code changes are approved.
metaschema-cli/src/main/java/gov/nist/secauto/metaschema/cli/commands/metapath/TestPathSubCommand.java (6)
1-26
: LGTM!The class declaration and imports are correctly implemented.
The code changes are approved.
27-48
: LGTM!The static final fields and static block are correctly implemented.
The code changes are approved.
50-69
: LGTM!The overridden methods
getName
,getDescription
,gatherOptions
, andgetExtraArguments
are correctly implemented.The code changes are approved.
71-77
: LGTM!The overridden method
validateOptions
is correctly implemented.The code changes are approved.
79-82
: LGTM!The overridden method
newExecutor
is correctly implemented.The code changes are approved.
84-118
: LGTM!The
executeCommand
method is correctly implemented. It performs the necessary checks and executes the metapath expression.The code changes are approved.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution. Resolves usnistgov/metaschema-java#241. Builds on metaschema-framework#96.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution. Resolves usnistgov/metaschema-java#241. Builds on metaschema-framework#96.
This work is continued in #102. |
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
… improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on metaschema-framework#96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241.
* introduce metapath expression evaluator subcommand * Fixed a schema generation bug causing an existing test to fail due to improper handling of JSON keys. Added basic support for arbitrary Metapath command execution, building on #96. Metapath execution allows for evaluating expressions without a module or instance. Resolves usnistgov/metaschema-java#241. --------- Co-authored-by: wandmagic <[email protected]>
Committer Notes
Attempting to add a metapath evaluator command
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: