Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncIterator tests fails #441

Closed
tshemsedinov opened this issue Dec 4, 2019 · 2 comments
Closed

AsyncIterator tests fails #441

tshemsedinov opened this issue Dec 4, 2019 · 2 comments
Labels
bug

Comments

@tshemsedinov
Copy link
Member

After dependency update #440 tests fails
See: https://travis-ci.org/metarhia/metasync/jobs/619382154
@nechaido
@lundibundi
Copy link
Member

That is due to the way metatests changed the handling of tests that return Promise (and therefore async).
I'll push to the branch the fix.

tshemsedinov added a commit that referenced this issue Dec 7, 2019
@tshemsedinov
Update dependencies, fix security alert
1bf9eb8 
- Fix eslint/prettier hints
- Fix async Iterator tests according to [email protected] changes

Fixes: #441
@tshemsedinov
Copy link
Member Author

https://travis-ci.org/metarhia/metasync/jobs/622009735
@lundibundi please see, is it related bug?

lundibundi pushed a commit to metarhia/iterator that referenced this issue Sep 13, 2020
@ivan-tymoshenko @tshemsedinov
@nechaido @JuliaGerasymenko @lundibundi
feat: implement AsyncIterator
f4f036b 
Refs: metarhia/metasync#385
Refs: metarhia/metasync#393
ORIGINAL-PR-URL: metarhia/metasync#396

Refs: metarhia/metasync#441
ORIGINAL-PR-URL: metarhia/metasync#440

Co-authored-by: Timur Shemsedinov <[email protected]>
Co-authored-by: Dmytro Nechai <[email protected]>
Co-authored-by: JuliaGerasymenko <[email protected]>
lundibundi pushed a commit to metarhia/iterator that referenced this issue Sep 13, 2020
@ivan-tymoshenko @tshemsedinov
@nechaido @JuliaGerasymenko @lundibundi
feat: implement AsyncIterator
ee2d9a3 
Refs: metarhia/metasync#385
Refs: metarhia/metasync#393
ORIGINAL-PR-URL: metarhia/metasync#396

Refs: metarhia/metasync#441
ORIGINAL-PR-URL: metarhia/metasync#440

Co-authored-by: Timur Shemsedinov <[email protected]>
Co-authored-by: Dmytro Nechai <[email protected]>
Co-authored-by: JuliaGerasymenko <[email protected]>
lundibundi pushed a commit to metarhia/iterator that referenced this issue Sep 13, 2020
@ivan-tymoshenko @tshemsedinov
@nechaido @JuliaGerasymenko @lundibundi
feat: implement AsyncIterator
d0b07ed 
Refs: metarhia/metasync#385
Refs: metarhia/metasync#393
ORIGINAL-PR-URL: metarhia/metasync#396

Refs: metarhia/metasync#441
ORIGINAL-PR-URL: metarhia/metasync#440

Co-authored-by: Timur Shemsedinov <[email protected]>
Co-authored-by: Dmytro Nechai <[email protected]>
Co-authored-by: JuliaGerasymenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tshemsedinov @lundibundi