Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing asserts with explicit errors + more #702

Merged
merged 3 commits into from
Sep 3, 2022
Merged

Replacing asserts with explicit errors + more #702

merged 3 commits into from
Sep 3, 2022

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Aug 31, 2022

  • Also:
    • Adding new error variants.
    • Cargo fmt and clippy fixes.
    • Removing a collection TODO since we solved
      a different way.
    • Adding #[allow(unreachable_patterns)] on one specific unsupported
      schema error.
    • Updating token-metadata to be a crates.io version.
    • Regenerating API.

@danenbm danenbm requested review from austbot and alexandruag August 31, 2022 20:36
@danenbm danenbm mentioned this pull request Aug 31, 2022
Merged
@danenbm danenbm requested a review from febo August 31, 2022 20:41
@danenbm danenbm marked this pull request as ready for review August 31, 2022 21:40
@danenbm danenbm requested a review from a team as a code owner August 31, 2022 21:40
@austbot
Copy link
Contributor

austbot commented Sep 2, 2022

looks good but there are some conflicts

austbot
austbot previously approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@austbot austbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when conflicst resolved

@danenbm danenbm force-pushed the danenbm/bubblegum-improve-errors branch from c694cde to 5910899 Compare September 2, 2022 22:30
@danenbm
Copy link
Contributor Author

danenbm commented Sep 2, 2022

looks good but there are some conflicts

Fixed merge conflicts

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Workflow Verify package library found differences when running yarn api:gen in the JS lib for fixed-price-sale. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2982192052.

@danenbm
Replacing asserts with explicit errors
a8e9c72 
- Also
  - Adding new error variants.
  - Updating `get_instruction_type()` to contain new instruction
discriminators.
  - Cargo fmt and clippy fixes.
  - Removing a collection TODO since we solved a different way.
  - Removing unreachable enum variant in match statement for schema
version error after team discussion.
@danenbm
Regenerating API
33b354e
@danenbm
Updating token-metadata version in Bubblegum
84881d7
@danenbm danenbm force-pushed the danenbm/bubblegum-improve-errors branch from d34c072 to 84881d7 Compare September 2, 2022 23:18
@danenbm
Copy link
Contributor Author

danenbm commented Sep 2, 2022

Workflow Verify package library found differences when running yarn api:gen in the JS lib for fixed-price-sale. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2982192052.

Removed the change for fixed-price-sale because I don't want to mix this issue in with this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Workflow Verify package library found differences when running yarn api:gen in the JS lib for fixed-price-sale. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2982333872.

@danenbm danenbm merged commit f15e31f into master Sep 3, 2022
@danenbm danenbm deleted the danenbm/bubblegum-improve-errors branch September 3, 2022 17:13
thlorenz added a commit that referenced this pull request Sep 6, 2022
@thlorenz
Merge branch 'master' into thlorenz/chore/auction-house-update-sdk-re…
be4471b 
…maining-accounts

* master:
  chore: stabilize auction-house tests in CI (#718)
  Update README.md (#713)
  build: update path filters to include program/js subdirs (#708)
  Replacing asserts with explicit errors + more (#702)
  Adding script to download SPL programs used for Bubblegum testing (#706)
  Update bubblegum to use spl version of Compression (#699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandruag alexandruag alexandruag approved these changes

@austbot austbot austbot approved these changes

@febo febo Awaiting requested review from febo

Assignees

@febo febo

@austbot austbot

@alexandruag alexandruag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danenbm @austbot @alexandruag @febo