Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rollup and Babel to create builds #93

Merged
merged 19 commits into from
May 9, 2022
Merged

Use Rollup and Babel to create builds #93

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6cc9478
feat: install and configure rollup
lorisleiva May 6, 2022
a1c46df
chore: remove some circular dependencies
lorisleiva May 6, 2022
a91c36c
feat: minify iife.min build
lorisleiva May 6, 2022
f1dcecd
feat: replace some env variables
lorisleiva May 6, 2022
7e94f35
feat: generate package.json to set type
lorisleiva May 6, 2022
a6b26ea
feat: polyfill assert from nested dependencies
lorisleiva May 6, 2022
fb7680f
feat: bundle more dependencies in iife and dedupe more
lorisleiva May 6, 2022
42444c5
feat: add polyfills to iife
lorisleiva May 6, 2022
292f517
chore: remove redundant assert polyfill
lorisleiva May 6, 2022
e28ea80
chore: update scripts and test build
lorisleiva May 6, 2022
55c8083
chore: temporary remove circular dependency warnings
lorisleiva May 6, 2022
4f61ab4
fix: export accountProviders so they don't get removed
lorisleiva May 6, 2022
75b7d3d
chore: add browser builds to package.json
lorisleiva May 6, 2022
b5b1b42
chore: remove some circular dependencies
lorisleiva May 7, 2022
ca3b4b1
chore: remove more circular dependencies
lorisleiva May 7, 2022
eecb83c
fix: remove instanceof usage
lorisleiva May 7, 2022
b205148
chore: remove proposal plugins
lorisleiva May 8, 2022
5f1d347
Merge branch 'main' into loris/rollup-again
lorisleiva May 9, 2022
35d6591
chore: remove unused dependencies
lorisleiva May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"preversion": "yarn check:publish-ready",
"postversion": "git push --follow-tags",
"clean": "rimraf dist",
"build": "yarn clean && rollup -c && ttsc",
"build": "yarn clean && ttsc && rollup -c",
"build:test": "ttsc -p test/tsconfig.json",
"amman:start": "DEBUG='amman:(info|error|debug)' amman start",
"amman:stop": "amman stop",
Expand Down
6 changes: 3 additions & 3 deletions src/types/IdentityDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { PublicKey, Transaction } from '@solana/web3.js';
import nacl from 'tweetnacl';
import { Driver } from './Driver';
import { IdentitySigner, Signer } from '@/types';
import { IdentitySigner } from '@/types';

export abstract class IdentityDriver extends Driver implements IdentitySigner {
public abstract publicKey: PublicKey;
Expand All @@ -13,8 +13,8 @@ export abstract class IdentityDriver extends Driver implements IdentitySigner {
return nacl.sign.detached.verify(message, signature, this.publicKey.toBytes());
}

public equals(that: Signer | PublicKey): boolean {
if (!(that instanceof PublicKey)) {
public equals(that: { publicKey: PublicKey } | PublicKey): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really belong in a build system update PR. Also I already fixed this, see #94 , so we'll just run into unnecessary conflicts.

if ('publicKey' in that) {
that = that.publicKey;
}

Expand Down