Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redeem printing v2 action and update instant sale #91

Merged
merged 8 commits into from
Dec 6, 2021

Conversation

kurpav
Copy link
Contributor

@kurpav kurpav commented Dec 3, 2021

Add redeem printing v2 action and updates instant sale to support the winning type

Tested on metaplex-foundation repo

src/Account.ts Show resolved Hide resolved
src/actions/instantSale.ts Show resolved Hide resolved
src/actions/redeemFullRightsTransferBid.ts Outdated Show resolved Hide resolved
src/actions/redeemPrintingV2Bid.ts Outdated Show resolved Hide resolved
export function getEditionOffset(winIndex: number) {
const offset = new BN(1);
// NOTE: not sure if this the right way to calculate it
return offset.add(new BN(winIndex));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@austbot thoughts?

src/errors.ts Show resolved Hide resolved
zaxozhu
zaxozhu previously approved these changes Dec 6, 2021
src/programs/auction/accounts/Auction.ts Outdated Show resolved Hide resolved
src/programs/auction/accounts/Auction.ts Show resolved Hide resolved
src/actions/redeemPrintingV2Bid.ts Show resolved Hide resolved
@kurpav kurpav merged commit fd4a3b3 into main Dec 6, 2021
@kurpav kurpav deleted the feature/redeem-printing-v2-bid-action branch December 6, 2021 13:16
@zaxozhu
Copy link
Contributor

zaxozhu commented Dec 6, 2021

🎉 This PR is included in version 4.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants