Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build fail issue on amman/src/cli/amman.ts caused by function cal… #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karlvlam
Copy link

@karlvlam karlvlam commented Apr 27, 2023

Here's the fix for the issue when we run yarn build. Fixing this would help the newbies to test easily. @thlorenz

$ yarn build
yarn run v1.22.19
$ yarn build:client && yarn build:amman
$ rimraf amman-client/dist && tsc -p amman-client/tsconfig.json
$ rimraf amman/dist && tsc -p amman/tsconfig.json
amman/src/cli/amman.ts:248:26 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.

248         assertCommitment(commitment)
                             ~~~~~~~~~~

amman/src/cli/amman.ts:253:11 - error TS2345: Argument of type '{}' is not assignable to parameter of type 'string'.

253           label!,
              ~~~~~~

amman/src/cli/amman.ts:299:45 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'boolean'.

299         await handleAccountCommand(address, includeTx, save)
                                                ~~~~~~~~~

amman/src/cli/amman.ts:331:11 - error TS2322: Type '{}' is not assignable to type 'string | string[]'.

331       let labels: string | string[] = args.label ?? []
              ~~~~~~

amman/src/cli/amman.ts:346:11 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'boolean'.

346           txOnly,
              ~~~~~~


Found 5 errors in the same file, starting at: amman/src/cli/amman.ts:248

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant