Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button label leaks into html tag as an attribute #65

Open
mlt opened this issue Apr 19, 2018 · 1 comment
Open

Button label leaks into html tag as an attribute #65

mlt opened this issue Apr 19, 2018 · 1 comment

Comments

@mlt
Copy link
Contributor

mlt commented Apr 19, 2018 •
edited
Loading

I think there should be no dup

tabulatr2/lib/tabulatr/data/button_builder.rb

Line 49 in e4badda

label = options.dup.delete(:label)
as it results in a button tag with an invalid attribute label.
mlt added a commit to mlt/tabulatr2 that referenced this issue Apr 19, 2018
@mlt
This closes metaminded#65
aa4de2f
@hanspolo
Copy link
Contributor

Thank you, I'll have a look on this.

mlt added a commit to mlt/tabulatr2 that referenced this issue May 10, 2018
@mlt
This closes metaminded#65
45e7892
mlt added a commit to mlt/tabulatr2 that referenced this issue May 22, 2018
@mlt
This closes metaminded#65
d0ad347
mlt added a commit to mlt/tabulatr2 that referenced this issue Jun 18, 2018
@mlt
This closes metaminded#65
2135e5a
mlt added a commit to mlt/tabulatr2 that referenced this issue Sep 23, 2018
@mlt
This closes metaminded#65
6140987
mlt added a commit to mlt/tabulatr2 that referenced this issue Oct 10, 2018
@mlt
This closes metaminded#65
d43c055
mlt added a commit to mlt/tabulatr2 that referenced this issue Oct 10, 2018
@mlt
This closes metaminded#65
6f0130a
mlt added a commit to mlt/tabulatr2 that referenced this issue Nov 25, 2019
@mlt
This closes metaminded#65
7139d77
mlt added a commit to mlt/tabulatr2 that referenced this issue Nov 28, 2019
@mlt
This closes metaminded#65
161dad0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlt @hanspolo