Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't play nicely with turbolinks 5 #48

Open
mlt opened this issue Oct 26, 2016 · 7 comments
Open

Doesn't play nicely with turbolinks 5 #48

mlt opened this issue Oct 26, 2016 · 7 comments

Comments

@mlt
Copy link
Contributor

mlt commented Oct 26, 2016

A table renders empty upon following a link to a page with tabulatr2 within an application bundled with turbolinks 5. Subsequent page reload results in table entries showing up. Everything works as expected with turbolinks 2.5.3

P.S. I'm on rails 4.2.7.
P.P.S. Also filtering JS seems to be messed up with turbolinks 5. Filter pane pops up and hides, comboboxes don't work.

@mlt
Copy link
Contributor Author

mlt commented Oct 31, 2016

I wonder if _events.js shall be augmented with turbolinks:load or something (didn't try it yet).

@mlt
Copy link
Contributor Author

mlt commented Oct 31, 2016

FYI: This workaround helped with tabulatr2 as well.

@mlt
Copy link
Contributor Author

mlt commented Nov 1, 2016

Perhaps a better approach would be to use event delegation as mentioned in Turbolinks docs (last paragraph in linked section).

@Crunch09
Copy link
Contributor

Hi @mlt ,
sorry for the long wait, maybe @no-dashes could shed some light on what the plans for tabulatr2 regarding turbolinks support are?

@mlt
Copy link
Contributor Author

mlt commented Dec 15, 2016

We, probably, want to prevent event propagation on filter tab expansion with return false or something. Otherwise it (turbolinks?) reloads the page and tab collapses.

mlt added a commit to mlt/tabulatr2 that referenced this issue Dec 30, 2016
mlt added a commit to mlt/tabulatr2 that referenced this issue Sep 28, 2017
mlt added a commit to mlt/tabulatr2 that referenced this issue Sep 28, 2017
mlt added a commit to mlt/tabulatr2 that referenced this issue Oct 4, 2017
mlt added a commit to mlt/tabulatr2 that referenced this issue May 10, 2018
mlt added a commit to mlt/tabulatr2 that referenced this issue May 22, 2018
mlt added a commit to mlt/tabulatr2 that referenced this issue Jun 18, 2018
mlt added a commit to mlt/tabulatr2 that referenced this issue Sep 23, 2018
mlt added a commit to mlt/tabulatr2 that referenced this issue Oct 10, 2018
mlt added a commit to mlt/tabulatr2 that referenced this issue Oct 10, 2018
@hanspolo
Copy link
Contributor

Hi, I'm currently refactoring the JS parts.
I will use your changes to support turbolinks after I'm done.

@mlt
Copy link
Contributor Author

mlt commented Oct 19, 2018

Nice! Let me know so I can rebase or something. Also I didn't test continuous scrolling :( It should also use event bubbling instead of binding for TL to work.

Can we have a gitter.im channel for tabulatr or something?

Also take a look at my fork. I ditched phantomjs in favor of selenium so modern JS can be tested since you are refactoring that.

mlt added a commit to mlt/tabulatr2 that referenced this issue Nov 25, 2019
mlt added a commit to mlt/tabulatr2 that referenced this issue Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants