-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't play nicely with turbolinks 5 #48
Comments
I wonder if _events.js shall be augmented with |
FYI: This workaround helped with tabulatr2 as well. |
Perhaps a better approach would be to use event delegation as mentioned in Turbolinks docs (last paragraph in linked section). |
Hi @mlt , |
We, probably, want to prevent event propagation on filter tab expansion with |
Hi, I'm currently refactoring the JS parts. |
Nice! Let me know so I can rebase or something. Also I didn't test continuous scrolling :( It should also use event bubbling instead of binding for TL to work. Can we have a gitter.im channel for tabulatr or something? Also take a look at my fork. I ditched phantomjs in favor of selenium so modern JS can be tested since you are refactoring that. |
A table renders empty upon following a link to a page with tabulatr2 within an application bundled with turbolinks 5. Subsequent page reload results in table entries showing up. Everything works as expected with turbolinks 2.5.3
P.S. I'm on rails 4.2.7.
P.P.S. Also filtering JS seems to be messed up with turbolinks 5. Filter pane pops up and hides, comboboxes don't work.
The text was updated successfully, but these errors were encountered: