Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Resolve network interface in agent. #704

Closed
wants to merge 10 commits into from

Conversation

meowjesty
Copy link
Member

@meowjesty meowjesty self-assigned this Nov 7, 2022
Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick - can we do maybe udp instead of tcp for less possible issues?

CHANGELOG.md Outdated Show resolved Hide resolved
@meowjesty meowjesty marked this pull request as ready for review November 8, 2022 00:02
Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!
bors r+

bors bot pushed a commit that referenced this pull request Nov 8, 2022
- Network interface in agent no longer resolves to `eth0` by default (`eth0` is still used if we can't find a suitable interface);
- Fixes #670 with the new `resolve_interface` approach;
@bors
Copy link

bors bot commented Nov 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Resolve network interface in agent. [Merged by Bors] - Resolve network interface in agent. Nov 8, 2022
@bors bors bot closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"unexpected response - expected env vars response None"
2 participants