Add more http mirroring layer integration tests. #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4lz
force-pushed
the
more-integration
branch
7 times, most recently
from
2c7c94c to
163d1c8
Compare
|
General comment: a bit too late in this case, but opt for small PRs - no need to get Flask + Go + Node in one go. Feel free to split Issues too to reflect that. |
t4lz
force-pushed
the
more-integration
branch
2 times, most recently
from
27bf4ca to
e8be805
Compare
t4lz
force-pushed
the
more-integration
branch
2 times, most recently
from
65bc21a to
5098cff
Compare
- Also disable file ops in http test.
t4lz
force-pushed
the
more-integration
branch
2 times, most recently
from
5b62e9d to
8beb2b1
Compare
Since there are now also other files with integration tests in mirrord-layer, it does not make sense to call that file `integration.rs`.
t4lz
force-pushed
the
more-integration
branch
from
8beb2b1 to
b99120f
Compare
t4lz
commented
Oct 10, 2022
eyalb181
requested changes
Oct 10, 2022
|
Converted to draft since it turns out go was still unstable. Now tried this new strategy from https://stackoverflow.com/questions/39320025/how-to-stop-http-listenandserve. Not sure about this yet since I have no experience with Go. |
eyalb181
approved these changes
Oct 10, 2022
tamasfe
pushed a commit
to tamasfe/mirrord
that referenced
this pull request
Oct 10, 2022
* Add http mirror layer integration test with FastAPI.
* Add http mirror layer integration test with node.
* Also disable file ops in http test.
* Add http mirror layer integration test with go.
* Send the layer a close connection message after sending data.
* Apps exit on all done, instead of on DELETE.
* build the go app in the tests so that new devs don't have to build it before running tests.
* changelog
* Rename http mirroring integration tests to `http_mirroring`.
- Since there are now also other files with integration tests in
mirrord-layer, it does not make sense to call that file
`integration.rs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#472