Many protocol adjustments #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cros` and `protocol_break` attribute to mark places we want to break on major updates. Add CI to verify that if protocol is changed, `Cargo.toml` is changed as well (to force bumps) Fix some of the structs being `OS` controlled, potentially breaking the protocol between different OS's. (`GetDEnts64(RemoteResult<GetDEnts64Response>),`)
t4lz
approved these changes
Jun 8, 2023
Co-authored-by: t4lz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change
mirrord-protocolto have its own versioning. addmirrord-macrosandprotocol_breakattribute to mark places we want to break on major updates.Add CI to verify that if protocol is changed,
Cargo.tomlis changed as well (to force bumps)Fix some of the structs being
OScontrolled, potentially breaking the protocol between different OS's. (GetDEnts64(RemoteResult<GetDEnts64Response>),)Closes #1355