Support JavaScript on IntelliJ #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4lz
force-pushed
the
node-brains
branch
3 times, most recently
from
e4ee3bb to
5255dcf
Compare
aviramha
requested changes
Apr 19, 2023
...orm/src/main/kotlin/com/metalbear/mirrord/products/webstorm/NodeRunConfigurationExtension.kt
Outdated
Show resolved
Hide resolved
...orm/src/main/kotlin/com/metalbear/mirrord/products/webstorm/NodeRunConfigurationExtension.kt
Outdated
Show resolved
Hide resolved
...orm/src/main/kotlin/com/metalbear/mirrord/products/webstorm/NodeRunConfigurationExtension.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Node.js on IntelliJ #1284
For some reason, the class that can be extended for node's run configuration extension point is a bit different than those of other languages/IDEs, so this works a bit differently than our other extension points.
This abstract class we have to extend forces us to override methods like
resetEditorFrom, and right now we don't do anything there, and we still don't exactly know if this could be a problem for editing node run configurations.In superficial tests I did not find any problem.
Leaving this here:
Some resources I used, for documentation