Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix config file disabled env #1018

Closed
wants to merge 2 commits into from

Conversation

DmitryDodzin
Copy link
Member

Fix incorrect behavior with env is disabled

[feature]
env = false

now should pass "*" to exclude

closes #1015

@DmitryDodzin
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 6, 2023
Fix incorrect behavior with env is disabled
```toml
[feature]
env = false
```
now should pass "*" to exclude

closes #1015
@bors
Copy link

bors bot commented Feb 6, 2023

Build failed:

@DmitryDodzin
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 6, 2023
Fix incorrect behavior with env is disabled
```toml
[feature]
env = false
```
now should pass "*" to exclude

closes #1015
@bors
Copy link

bors bot commented Feb 6, 2023

Timed out.

@aviramha
Copy link
Member

aviramha commented Feb 7, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 7, 2023
Fix incorrect behavior with env is disabled
```toml
[feature]
env = false
```
now should pass "*" to exclude

closes #1015
@bors
Copy link

bors bot commented Feb 7, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix config file disabled env [Merged by Bors] - Fix config file disabled env Feb 7, 2023
@bors bors bot closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env = false in configuration doesn't disable env
3 participants