Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension <> CLI Interface #780

Closed
aviramha opened this issue Nov 23, 2022 · 2 comments
Closed

Extension <> CLI Interface #780

aviramha opened this issue Nov 23, 2022 · 2 comments
Assignees

Comments

@aviramha
Copy link
Member

aviramha commented Nov 23, 2022

Make the extensions use the CLI.

  1. CLI will provide targetable pods/deployments, instead of having it implemented separately in each extension.
  2. It will pass command line arguments and environment variables passed on command line to the process. This should resolve Passing cli arguments from pod to local application #772 .
  3. It will create the agent for the process, which will let us pass environment variables to it from the outside. This will fix Go's Env vars don't work on macos M1, go version go1.18.4 darwin/arm64 #373 because we can remove the code that sets env from inside the process
bors bot pushed a commit that referenced this issue Dec 9, 2022
refer #780 #811 

Co-authored-by: Mehul <[email protected]>
@aviramha
Copy link
Member Author

Done vscode. IntelliJ left.

@aviramha
Copy link
Member Author

aviramha commented Jan 1, 2023

Done with #849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants