-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to pause the remote pod #712
Comments
Should we use docker's And maybe if it's not docker we can still use cgroup freezer which is apparently what docker uses to pause? |
I wouldn't bother with |
Saw your reply too late. But now we have a neat implementation using the docker/containerd API to pause the container instead of doing it ourselves :) |
Is adding this feature to the IDEs part of this issue or should I open separate issues for that? |
No, this feature should be possible to enable from the config file - VS Code already uses it and IntelliJ is underway. |
#712 Add the `--pause` flag which pauses the target container while there are clients connected to the agent. When the last client disconnects the container resumes. Currently the pause behaviour is determined in the creation of the agent. So if clients from a different run want to reuse the same agent they will just get the existing pause behaviour of the agent.
That exactly what is preventing me from using Telepresence 2. Many thanks 🙏🎉 |
Today, mirrord runs side-by-side with the existing pod/s. Many users want to "replace" the remote pod.
I think the best, nicest, approach wouldn't be to really replace the replicaset with our agent, but still run it side by side, making the agent send
SIGSTOP
to the pod's process, thenSIGCONT
when agent finishes running.This way we're just pausing the activity of the original pod.
Small hint- I think we should have a loop that sends SIGSTOP every few seconds, as there might be some OS stuff that will send
SIGCONT
without us knowing/wanting.Suggestion - flag would be
--pause
-p
The text was updated successfully, but these errors were encountered: