Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirrord teams waitlist signup command #10

Merged
merged 10 commits into from
Jun 28, 2023

Conversation

DmitryDodzin
Copy link
Member

@DmitryDodzin DmitryDodzin commented Jun 22, 2023

@Razz4780
Copy link
Contributor

Will this be visible to the users? Maybe we should also add a popup or sth

@eyalb181
Copy link
Member

Will this be visible to the users? Maybe we should also add a popup or sth

Indeed, see metalbear-co/mirrord#1306 for the planned changes

@eyalb181
Copy link
Member

@DmitryDodzin General note - if I click "Show deployments", I expect deployments to show next time I run mirrord, rather than pods again

@DmitryDodzin
Copy link
Member Author

I used lastTarget to determine when to show deployments or pods next time it is run

src/waitlist.ts Outdated Show resolved Hide resolved
src/waitlist.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/waitlist.ts Outdated Show resolved Hide resolved
DmitryDodzin and others added 3 commits June 27, 2023 18:35
@DmitryDodzin DmitryDodzin added this pull request to the merge queue Jun 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2023
@DmitryDodzin DmitryDodzin added this pull request to the merge queue Jun 28, 2023
Merged via the queue into metalbear-co:main with commit ca8ba3b Jun 28, 2023
@DmitryDodzin DmitryDodzin deleted the whitelist-signup branch June 28, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode target selection don't show deployment targets
3 participants