Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking active config across moves #61

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Tracking active config across moves #61

merged 3 commits into from
Jul 21, 2023

Conversation

Razz4780
Copy link
Contributor

Closes #60

eyalb181
eyalb181 requested changes Jul 21, 2023
View reviewed changes
Copy link
Member

@eyalb181 eyalb181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few little comments

modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordActiveConfigWatch.kt Show resolved Hide resolved
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordActiveConfigWatch.kt Show resolved Hide resolved
eyalb181
eyalb181 requested changes Jul 21, 2023
View reviewed changes
Copy link
Member

@eyalb181 eyalb181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few little comments

@Razz4780 Razz4780 added this pull request to the merge queue Jul 21, 2023
Merged via the queue into metalbear-co:main with commit 5bc859d Jul 21, 2023
@Razz4780 Razz4780 deleted the sticky-active-config branch July 21, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalb181 eyalb181 eyalb181 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update active config to the new location when it's moved
2 participants
@Razz4780 @eyalb181